Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4267] Add management command to migrate existing configurations #4536

Closed
wants to merge 1 commit into from

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jul 17, 2024

Originally for #4267

Relates to #4541 (although I think this can be merged independently)

Changes

Add a management command to migrate V1 and V2 configurations.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@Viicos Viicos force-pushed the feature/4267-command branch from ec9dbf8 to d38af7a Compare July 19, 2024 09:13
@Viicos Viicos marked this pull request as ready for review July 19, 2024 09:34
@Viicos Viicos force-pushed the feature/4267-command branch 3 times, most recently from df3ef4b to dcade59 Compare July 19, 2024 13:37
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 84.05797% with 11 lines in your changes missing coverage. Please review.

Project coverage is 96.56%. Comparing base (a0e2e18) to head (468a8af).
Report is 622 commits behind head on master.

Files with missing lines Patch % Lines
.../management/commands/migrate_objects_api_config.py 82.53% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4536      +/-   ##
==========================================
- Coverage   96.60%   96.56%   -0.04%     
==========================================
  Files         725      726       +1     
  Lines       24125    24197      +72     
  Branches     2870     2885      +15     
==========================================
+ Hits        23305    23366      +61     
- Misses        559      567       +8     
- Partials      261      264       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos Viicos force-pushed the feature/4267-command branch from dcade59 to cdd2db5 Compare July 23, 2024 10:48
@Viicos
Copy link
Contributor Author

Viicos commented Jul 23, 2024

Not sure if the remaining coverage bits should be properly addressed

@Viicos Viicos force-pushed the feature/4267-command branch from cdd2db5 to 50831f7 Compare July 23, 2024 10:52
@Viicos Viicos force-pushed the feature/4267-command branch from 50831f7 to 468a8af Compare July 23, 2024 12:07
@sergei-maertens sergei-maertens marked this pull request as draft July 29, 2024 11:36
@sergei-maertens
Copy link
Member

Closing this - the way we're adding the new functionality in a backwards compatible way relieves the pressure for a migration tool.

@sergei-maertens sergei-maertens deleted the feature/4267-command branch November 27, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants