-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4395] Add flag for updating an object to the ObjectsAPI registration #4538
Merged
sergei-maertens
merged 2 commits into
master
from
task/4395-objects-api-flag-for-updating-existing-objects
Jul 26, 2024
Merged
[#4395] Add flag for updating an object to the ObjectsAPI registration #4538
sergei-maertens
merged 2 commits into
master
from
task/4395-objects-api-flag-for-updating-existing-objects
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaszig
commented
Jul 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4538 +/- ##
==========================================
- Coverage 96.60% 96.58% -0.02%
==========================================
Files 725 725
Lines 24125 24146 +21
Branches 2870 3175 +305
==========================================
+ Hits 23305 23321 +16
- Misses 559 567 +8
+ Partials 261 258 -3 ☔ View full report in Codecov by Sentry. |
vaszig
force-pushed
the
task/4395-objects-api-flag-for-updating-existing-objects
branch
2 times, most recently
from
July 22, 2024 07:24
7cd099f
to
97b23f9
Compare
Viicos
suggested changes
Jul 23, 2024
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/registrations/objectsapi/V2ConfigFields.js
Outdated
Show resolved
Hide resolved
vaszig
force-pushed
the
task/4395-objects-api-flag-for-updating-existing-objects
branch
5 times, most recently
from
July 24, 2024 09:12
33a3eb1
to
43bc53b
Compare
Viicos
reviewed
Jul 24, 2024
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
vaszig
force-pushed
the
task/4395-objects-api-flag-for-updating-existing-objects
branch
from
July 24, 2024 09:51
43bc53b
to
4a7efb8
Compare
sergei-maertens
requested changes
Jul 25, 2024
src/openforms/js/components/admin/form_design/registrations/objectsapi/LegacyConfigFields.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/registrations/objectsapi/V2ConfigFields.js
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
vaszig
force-pushed
the
task/4395-objects-api-flag-for-updating-existing-objects
branch
from
July 25, 2024 11:59
4a7efb8
to
58ebf87
Compare
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
vaszig
force-pushed
the
task/4395-objects-api-flag-for-updating-existing-objects
branch
from
July 25, 2024 14:04
58ebf87
to
d865336
Compare
src/openforms/registrations/contrib/objects_api/tests/test_backend.py
Outdated
Show resolved
Hide resolved
vaszig
force-pushed
the
task/4395-objects-api-flag-for-updating-existing-objects
branch
from
July 26, 2024 06:05
d865336
to
084cf40
Compare
sergei-maertens
approved these changes
Jul 26, 2024
sergei-maertens
deleted the
task/4395-objects-api-flag-for-updating-existing-objects
branch
July 26, 2024 08:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4395
update_existing_object
flag to the ObjectsAPI (both versions). This will be used in combination withsubmission.initial_data_reference
in order to update an existing object and not recreate it.Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene