Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4395] Add flag for updating an object to the ObjectsAPI registration #4538

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jul 18, 2024

Closes #4395

  • Added update_existing_object flag to the ObjectsAPI (both versions). This will be used in combination with submission.initial_data_reference in order to update an existing object and not recreate it.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft July 18, 2024 14:16
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (9eafad5) to head (084cf40).
Report is 516 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4538      +/-   ##
==========================================
- Coverage   96.60%   96.58%   -0.02%     
==========================================
  Files         725      725              
  Lines       24125    24146      +21     
  Branches     2870     3175     +305     
==========================================
+ Hits        23305    23321      +16     
- Misses        559      567       +8     
+ Partials      261      258       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig force-pushed the task/4395-objects-api-flag-for-updating-existing-objects branch 2 times, most recently from 7cd099f to 97b23f9 Compare July 22, 2024 07:24
@vaszig vaszig marked this pull request as ready for review July 22, 2024 07:32
@vaszig vaszig force-pushed the task/4395-objects-api-flag-for-updating-existing-objects branch 5 times, most recently from 33a3eb1 to 43bc53b Compare July 24, 2024 09:12
@vaszig vaszig force-pushed the task/4395-objects-api-flag-for-updating-existing-objects branch from 43bc53b to 4a7efb8 Compare July 24, 2024 09:51
@vaszig vaszig force-pushed the task/4395-objects-api-flag-for-updating-existing-objects branch from 4a7efb8 to 58ebf87 Compare July 25, 2024 11:59
@vaszig vaszig force-pushed the task/4395-objects-api-flag-for-updating-existing-objects branch from 58ebf87 to d865336 Compare July 25, 2024 14:04
@vaszig vaszig force-pushed the task/4395-objects-api-flag-for-updating-existing-objects branch from d865336 to 084cf40 Compare July 26, 2024 06:05
@sergei-maertens sergei-maertens merged commit 08f946d into master Jul 26, 2024
31 of 32 checks passed
@sergei-maertens sergei-maertens deleted the task/4395-objects-api-flag-for-updating-existing-objects branch July 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flag on Objects API registration to update existing objects instead of creating new ones
3 participants