Ensure payment email is sent, irrespective of wait_for_payment registration mode #4549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test to assert that two emails are sent when registration is deferred until payment is received.
Payment emails may need to go to a billing department, which doesn't need access to the registration details. Sending one email doesn't imply the other, so ensure that both are sent if the recipients are not the same.
sergei-maertens
added
the
needs-backport
sergei-maertens
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4549 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 725 725
Lines 24125 24129 +4
Branches 2870 2871 +1
=======================================
+ Hits 23305 23309 +4
Misses 559 559
Partials 261 261 ☔ View full report in Codecov by Sentry. |
vaszig
approved these changes
Jul 23, 2024
sergei-maertens
deleted the
issue/4334-ensure-payment-email-is-always-sent
branch
sergei-maertens
added a commit
that referenced
this pull request
Jul 23, 2024
Payment emails may need to go to a billing department, which doesn't need access to the registration details. Sending one email doesn't imply the other, so ensure that both are sent if the recipients are not the same. Backport-of: #4549
sergei-maertens
added a commit
that referenced
this pull request
Jul 23, 2024
Payment emails may need to go to a billing department, which doesn't need access to the registration details. Sending one email doesn't imply the other, so ensure that both are sent if the recipients are not the same. Backport-of: #4549
sergei-maertens
added a commit
that referenced
this pull request
Jul 23, 2024
Payment emails may need to go to a billing department, which doesn't need access to the registration details. Sending one email doesn't imply the other, so ensure that both are sent if the recipients are not the same. Backport-of: #4549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4334
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene