Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.12 #4553

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Upgrade to Python 3.12 #4553

merged 8 commits into from
Jul 24, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jul 23, 2024

Closes #3197

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Bump dependencies that require building
Switch from pyscopg2 to pyscopg (3), psycopg2 has no wheels and build fails one 3.12.
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (1033b07) to head (533f12b).
Report is 484 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4553      +/-   ##
==========================================
- Coverage   96.60%   96.56%   -0.04%     
==========================================
  Files         725      725              
  Lines       24129    24131       +2     
  Branches     2871     3175     +304     
==========================================
- Hits        23309    23303       -6     
- Misses        559      569      +10     
+ Partials      261      259       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos Viicos marked this pull request as draft July 23, 2024 14:01
Viicos added 2 commits July 23, 2024 16:50
Deprecated helper was removed
Changes in the way subTest works internally
@Viicos Viicos force-pushed the python-312 branch 2 times, most recently from 9365892 to e98f1b8 Compare July 23, 2024 15:25
@Viicos Viicos marked this pull request as ready for review July 23, 2024 19:09
@Viicos Viicos requested a review from sergei-maertens July 23, 2024 20:10
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice, I'm curious if we'll see the performance improvements in APM

@Viicos Viicos merged commit 9fa0b64 into master Jul 24, 2024
16 of 18 checks passed
@Viicos Viicos deleted the python-312 branch July 24, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Python 3.12
2 participants