Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4519] Decrease horizontal space of form variable dropdowns #4558

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jul 24, 2024

Closes #4519

Changes

  • Added class name to the VariableSelection in order to define max-inline-size for the form variable dropdowns

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (5580da4) to head (7782053).
Report is 493 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4558   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         725      725           
  Lines       24131    24131           
  Branches     3175     3175           
=======================================
  Hits        23303    23303           
  Misses        569      569           
  Partials      259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens self-requested a review July 25, 2024 13:41
@vaszig vaszig force-pushed the fix/4519-max-size-for-formvariable-dropdowns branch from 9862455 to 7782053 Compare July 25, 2024 14:45
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge and backport tomorrow

@sergei-maertens sergei-maertens merged commit c04f0fa into master Jul 26, 2024
26 checks passed
@sergei-maertens sergei-maertens deleted the fix/4519-max-size-for-formvariable-dropdowns branch July 26, 2024 08:32
sergei-maertens pushed a commit that referenced this pull request Jul 26, 2024
sergei-maertens pushed a commit that referenced this pull request Jul 26, 2024
@sergei-maertens
Copy link
Member

Backports:

2.5.x was not really affected by this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form variable dropdowns take up too much horizontal space
2 participants