Address flakiness in tests #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sergei-maertens
commented
Jul 26, 2024
•
sergei-maertens
commented
- Report the random state of factory body - this may help in reproducing flaky tests.
- Fixed a cache isolation/reset causing flaky tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4565 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 725 725
Lines 24150 24151 +1
Branches 3176 3176
=======================================
+ Hits 23325 23326 +1
Misses 567 567
Partials 258 258 ☔ View full report in Codecov by Sentry. |
|
well, that test flakiness does not appear to be due to factory boy random state, can't reproduce locally yet :( |
sergei-maertens
changed the title
This may help in reproducing flaky tests.
The cache is shared between tests and when using Redis, even between parallel test processes. Certain global configuration options can affect other tests.
There's a possible race condition here that the clicks happen too quickly and the state change was not processed yet and the old state is then sent to the backend.
sergei-maertens
force-pushed
the
chore/test-flakiness
branch
from
513f429 to
0062214
Compare
|
Going to merge this one as-is, and other issues that pop up I will try to investigate asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.