Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4582] Weekly update SAML metadata for DigiD/Eherkenning #4626

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Aug 30, 2024

Closes #4582

Changes

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.68%. Comparing base (c25cb2b) to head (905732e).
Report is 548 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4626   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files         732      732           
  Lines       24649    24654    +5     
  Branches     3229     3230    +1     
=======================================
+ Hits        23832    23837    +5     
  Misses        564      564           
  Partials      253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig marked this pull request as draft September 2, 2024 08:44
@vaszig vaszig marked this pull request as ready for review September 4, 2024 07:24
@vaszig vaszig force-pushed the feature/4582-add-weekly-celery-task-for-updating-saml-metadata branch from 2474d5d to 905732e Compare September 4, 2024 08:01
@sergei-maertens sergei-maertens merged commit 62b5bc1 into master Sep 4, 2024
31 of 34 checks passed
@sergei-maertens sergei-maertens deleted the feature/4582-add-weekly-celery-task-for-updating-saml-metadata branch September 4, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Periodically update SAML metadata from brokers
2 participants