UX improvements: modal registration forms for email and stuf #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
sergei-maertens
changed the title
sergei-maertens
force-pushed
the
feature/4686-modal-registration-forms-for-email-and-stuf
branch
from
9c246fe to
7ab8561
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4742 +/- ##
=========================================
Coverage ? 96.55%
=========================================
Files ? 748
Lines ? 25410
Branches ? 3358
=========================================
Hits ? 24535
Misses ? 610
Partials ? 265 ☔ View full report in Codecov by Sentry. |
Otherwise it would be too easy for form designers to miss the option, let's make it clear that at least one email address must be entered.
Similar to the case properties, we can put the payment update mappings in a separate tab to de-clutter the UI. Next commit will then use the existing VariableMapping component to manage the actual mappings.
…ping Some code repetition, but at least we are now using consistent UI components for mapping from/to form variables in various places.
sergei-maertens
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
@robinmolen nice work! I did some minor tweaks w/r to the layout and organization of elements, and one big rework for the StUF payment variable mappings - that one has been rewritten using the existing VariableMapping component UX. Please review that commit to see the changes :)
Created a generic component for the button-that-opens-modal with error icon next to it, which renders the plugin-specific configuration form inside. This puts the less elegant code in a nice isolated box instead of spreading across the code base.
…correct wrong texts
sergei-maertens
deleted the
feature/4686-modal-registration-forms-for-email-and-stuf
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4686
Changes
The registration forms for Email and StUF-ZDS now use React components, instead of react-json-schema-form generated forms. This allows us to share styling and keep the styling uniform across forms. These changes also improve the user experience, by providing a simular form layout/logic as the other registration inline forms.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene