-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4418] Add addressNl specific mappings to Objects API registration (variables tab) #4751
[#4418] Add addressNl specific mappings to Objects API registration (variables tab) #4751
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4751 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 749 749
Lines 25540 25575 +35
Branches 3377 3384 +7
=======================================
+ Hits 24674 24708 +34
Misses 604 604
- Partials 262 263 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
243a9ca
to
284877f
Compare
31fba07
to
0f5fff7
Compare
...s/admin/form_design/registrations/objectsapi/GenericObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...s/admin/form_design/registrations/objectsapi/GenericObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...s/admin/form_design/registrations/objectsapi/GenericObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Outdated
Show resolved
Hide resolved
0f5fff7
to
0a47362
Compare
041b38d
to
44a63cd
Compare
FYI, we have to take into consideration the old forms that they already may have addressNL |
44a63cd
to
2e11645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional remarks:
-
Is it possible to disable/remove the "map to geometry field" row/option when configuring an AddressNL component?
-
The checkbox looks a bit odd because the label is specified before the checkbox itself:
Standard Django form styling puts this in a different order:
If we change this (please do), then I think the "map geometry field" needs the same treatment :)
-
The "show json schema" component doesn't seem to make a lot of sense when mapping specific sub-components
"Normally" this shows the json schema of the selected property from the object type when selecting a target path. This isn't relevant when mapping in more detail, unless you use this component for each nested target path, which will probably clutter too much, so I'd just not display it at all when mapping the sub components.
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Outdated
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Outdated
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Outdated
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Show resolved
Hide resolved
...admin/form_design/registrations/objectsapi/AddressNlObjectsApiVariableConfigurationEditor.js
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/submission_registration.py
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/submission_registration.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/submission_registration.py
Outdated
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/submission_registration.py
Show resolved
Hide resolved
2e11645
to
2d8f125
Compare
2d8f125
to
8371e62
Compare
Just a reminder for the translations and for #4751 (comment) |
I will do translations separately and I'll take a look at the data migration remark. |
Closes #4418
Changes
This PR handles the frontend part of the task
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene