-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-record VCR cassettes #4781
Merged
vaszig
merged 13 commits into
master
from
release/3.0.0-alpha.0-re-record-vcr-cassettes
Oct 23, 2024
Merged
Re-record VCR cassettes #4781
vaszig
merged 13 commits into
master
from
release/3.0.0-alpha.0-re-record-vcr-cassettes
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4781 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 746 746
Lines 25271 25271
Branches 3332 3332
=======================================
Hits 24406 24406
Misses 602 602
Partials 263 263 ☔ View full report in Codecov by Sentry. |
sergei-maertens
requested changes
Oct 22, 2024
src/openforms/contrib/kvk/tests/files/DigiCert_Global_Root_G2.crt
Outdated
Show resolved
Hide resolved
vaszig
force-pushed
the
release/3.0.0-alpha.0-re-record-vcr-cassettes
branch
from
October 23, 2024 07:18
e3ac878
to
0665151
Compare
sergei-maertens
approved these changes
Oct 23, 2024
vaszig
force-pushed
the
release/3.0.0-alpha.0-re-record-vcr-cassettes
branch
2 times, most recently
from
October 23, 2024 10:24
fe3292c
to
53ecb98
Compare
vaszig
force-pushed
the
release/3.0.0-alpha.0-re-record-vcr-cassettes
branch
from
October 23, 2024 10:25
53ecb98
to
26cb8bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4777 (partially)
(CERTIFICATE_VERIFY_FAILED)
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene