Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Camunda registration options + drop RJSF #4807

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

sergei-maertens
Copy link
Member

No ticket, follow up on #4806

Changes

  • Removed wrappers around RJSF from Camunda registration options, otherwise it's left untouched
  • Removed vendor workarounds
  • Removed RJSF dependency

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (b96d2ae) to head (ef6cac1).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4807   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         748      748           
  Lines       25423    25423           
  Branches     3362     3362           
=======================================
  Hits        24548    24548           
  Misses        610      610           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens force-pushed the feature/refactor-camunda-registration-options branch 2 times, most recently from 5ed28de to ce8d178 Compare November 8, 2024 18:24
We can drop the wrapper code and vendor SCSS fixes for this library,
as it is now no longer used.
@sergei-maertens sergei-maertens force-pushed the feature/refactor-camunda-registration-options branch from ce8d178 to ef6cac1 Compare November 12, 2024 12:01
@sergei-maertens sergei-maertens merged commit c47e11b into master Nov 12, 2024
32 of 34 checks passed
@sergei-maertens sergei-maertens deleted the feature/refactor-camunda-registration-options branch November 12, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants