💥 Drop legacy formio translation converter #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4828 +/- ##
==========================================
- Coverage 96.57% 96.57% -0.01%
==========================================
Files 748 747 -1
Lines 25448 25400 -48
Branches 3369 3355 -14
==========================================
- Hits 24576 24529 -47
Misses 608 608
+ Partials 264 263 -1 ☔ View full report in Codecov by Sentry. |
sergei-maertens
changed the title
sergei-maertens
force-pushed
the
cleanup/3283-remove-fd-translation-converter
branch
from
08f1a17 to
051fb2f
Compare
stevenbal
requested changes
Nov 18, 2024
Per the deprecation warning we drop support for exports containing the legacy translation store.
The previous commit removed a source of hypothesis flakiness, but these strategies can be very useful to simulate weird/unexpected components that may crash the application or migrations, so It Was Time to fix the recursion issues. Turns out that defining a deferred strategy was all that was needed to prevent the recursion in hypothesis. Additionally, some type checker workarounds could be removed from existing tests 🎉
The tested behaviours are covered by automated end-to-end tests, and I doubt anyone was actually still reading these docs.
Was looking for the backend testing documentation and came across more documentation that is outdated, so might just fix it along the way.
sergei-maertens
force-pushed
the
cleanup/3283-remove-fd-translation-converter
branch
from
051fb2f to
595c8ba
Compare
sergei-maertens
deleted the
cleanup/3283-remove-fd-translation-converter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3283
Per the deprecation warning we drop support for exports containing the legacy translation store. This also gave the opportunity to clean up some known technical debt for the search strategies, and now that they're stable, they are also documented as available testing tool.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene