-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-record VCR cassettes #4857
Re-record VCR cassettes #4857
Conversation
7e622e1
to
9ef99f1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4857 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 751 751
Lines 25679 25679
Branches 3395 3395
=======================================
Hits 24809 24809
Misses 608 608
Partials 262 262 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't see anything odd when doing a diff check using
git diff HEAD..origin/release/3.0.0-alpha.1-re-record-vcr-cassettes
Closes #4849 partly
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene