Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-record VCR cassettes #4857

Merged
merged 11 commits into from
Nov 26, 2024

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Nov 26, 2024

Closes #4849 partly

  • Re-recorded all cassettes (except for the ones which make use of known-broken links)

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft November 26, 2024 10:57
@vaszig vaszig force-pushed the release/3.0.0-alpha.1-re-record-vcr-cassettes branch from 7e622e1 to 9ef99f1 Compare November 26, 2024 11:06
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (8cc5eb4) to head (50a8603).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4857   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         751      751           
  Lines       25679    25679           
  Branches     3395     3395           
=======================================
  Hits        24809    24809           
  Misses        608      608           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig marked this pull request as ready for review November 26, 2024 11:20
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see anything odd when doing a diff check using

git diff HEAD..origin/release/3.0.0-alpha.1-re-record-vcr-cassettes

@sergei-maertens sergei-maertens merged commit 5082b55 into master Nov 26, 2024
37 checks passed
@sergei-maertens sergei-maertens deleted the release/3.0.0-alpha.1-re-record-vcr-cassettes branch November 26, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare release 3.0.0-alpha.1
2 participants