[#3283] Remove oldstyle appointments flow #4872

vaszig · 2024-11-29T14:59:02Z

Closes #3283 partly

Changes

Updated code to adhere to the new appointments flow
Now we do not extract the appointment data from a submission
Removed frontend/admin code to manage appointment (tab)
Removed support for fixed customer fields
Removed "invalid input serializer -> return empty result list" in favour of raising a validation error exception

Checklist

Check off the items that are completed or not relevant.

Impact on features
- Checked copying a form
- Checked import/export of a form
- Config checks in the configuration overview admin page
- Problem detection in the admin email digest is handled
Release management
- I have labelled the PR as "needs-backport" accordingly
I have updated the translations assets (you do NOT need to provide translations)
- Ran ./bin/makemessages_js.sh
- Ran ./bin/compilemessages_js.sh
Commit hygiene
- Commit messages refer to the relevant Github issue
- Commit messages explain the "why" of change, not the how

src/openforms/js/components/admin/form_design/Appointments.js

src/openforms/js/components/admin/form_design/form-creation-form.js

src/openforms/emails/templates/emails/templatetags/appointment_information.html

src/openforms/appointments/tasks.py

src/openforms/submissions/tasks/__init__.py

src/openforms/appointments/management/commands/appointment.py

src/openforms/formio/formatters/tests/test_kitchensink.py

docs/manual/forms/examples/appointment_creation.rst

sergei-maertens

OMG so much code being removed it's like it's almost Christmas!

src/openforms/appointments/tasks.py

src/openforms/appointments/core.py

src/openforms/submissions/query.py

src/openforms/emails/templatetags/appointments.py

sergei-maertens

and obviously the CI failures need to be looked into!

src/openforms/js/components/admin/form_design/form-creation-form.js

Legacy version of appointments used to allow changing and cancelling an appointment. Now only the latter one is allowed and implemented, so we get rid of the code/texts which have to do with changing one.

The appointments views used to have a deprecation warning which had to do with what we return to the frontend. Formio wasn't handling correctly the raised error of a serializer (serializer.is_valid(raise_exception=True)) so we had to return an empty list instead. Now, we have custome react code and we can make the API calls when we are ready so we avoid errors, but if any they will now be raised.

Deleted the tests which were refering to the old flow as well. The new appointments do not have summary or steps so no need to test with such a configuration.

codecov · 2024-12-11T10:27:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (27a9852) to head (b956f22).
Report is 28 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4872      +/-   ##
==========================================
- Coverage   96.62%   96.57%   -0.05%     
==========================================
  Files         757      757              
  Lines       25942    25731     -211     
  Branches     3417     3379      -38     
==========================================
- Hits        25066    24850     -216     
- Misses        613      616       +3     
- Partials      263      265       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vaszig marked this pull request as draft November 29, 2024 14:59

vaszig force-pushed the cleanup/3283-remove-oldstyle-appointments-flow branch 2 times, most recently from 5768477 to 011defa Compare December 2, 2024 15:36

vaszig marked this pull request as ready for review December 2, 2024 15:49

vaszig mentioned this pull request Dec 3, 2024

Deprecations to remove in 3.0 #3283

Closed

23 tasks