Fix incorrect detection of cosign being required blocking the registration #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4889 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 757 757
Lines 25945 25952 +7
Branches 3419 3420 +1
=======================================
+ Hits 25069 25076 +7
Misses 613 613
Partials 263 263 ☔ View full report in Codecov by Sentry. |
sergei-maertens
force-pushed
the
issue/3901-cosign-required-regression-test
branch
2 times, most recently
from
e7529cf to
bdfca4c
Compare
vaszig
approved these changes
Dec 10, 2024
A required but hidden cosign component should not block the submission registration.
When cosign components are (dynamically) hidden, this effectively makes the form/submission *not* a cosign form. However, due to logic not being taken into account, the mere presence of a required cosign component would block the registration by waiting for cosign.
sergei-maertens
force-pushed
the
issue/3901-cosign-required-regression-test
branch
from
bdfca4c to
3bd0286
Compare
nah it was an old thing, not something that broke in my cosign rework. the refactor made it possible to fix this older reported issue :) |
sergei-maertens
deleted the
issue/3901-cosign-required-regression-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3901 - depends on #4888
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene