Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Remove conversion of form step URL to form step UUID #4892

Merged

Conversation

sergei-maertens
Copy link
Member

Part of #3283

Fully qualified URLs to resolve a form step have been deprecated for a while, since they're not portable across environments with different base URLs.

Now the compatibility code is removed too, which may break old exports.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (ae74347) to head (68a21bb).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4892      +/-   ##
==========================================
- Coverage   96.60%   96.60%   -0.01%     
==========================================
  Files         754      754              
  Lines       25853    25844       -9     
  Branches     3415     3414       -1     
==========================================
- Hits        24976    24967       -9     
  Misses        613      613              
  Partials      264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fully qualified URLs to resolve a form step have been deprecated for
a while, since they're not portable across environments with different
base URLs.

Now the compatibility code is removed too, which may break old exports.
@sergei-maertens sergei-maertens force-pushed the cleanup/3283-remove-deprecated-formstep-logic branch from 61dfe27 to 68a21bb Compare December 9, 2024 10:22
@sergei-maertens sergei-maertens merged commit 48773c8 into master Dec 9, 2024
33 of 34 checks passed
@sergei-maertens sergei-maertens deleted the cleanup/3283-remove-deprecated-formstep-logic branch December 9, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants