💚 Fix flaky msgraph test #4896
Merged
💚 Fix flaky msgraph test #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lack of deterministic ordering when processing the submission attachments can cause tests to sometimes fail in CI. When no explicit ordering is specified, Postgres figures out an ordering which tends to correspond to how the tuples/records are stored on disk, and on particular bad alignment of the stars the later-created record can appear before earlier ones, being returned in a non-intuitive order. For this reason, you should always make ordering explicit or if ordering doesn't matter, write assertions without assuming any ordering. In this case, making the order explicit is the simplest fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4896 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 757 757
Lines 25945 25945
Branches 3419 3419
=======================================
Hits 25069 25069
Misses 613 613
Partials 263 263 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of deterministic ordering when processing the submission attachments can cause tests to sometimes fail in CI.
When no explicit ordering is specified, Postgres figures out an ordering which tends to correspond to how the tuples/records are stored on disk, and on particular bad alignment of the stars the later-created record can appear before earlier ones, being returned in a non-intuitive order. For this reason, you should always make ordering explicit or if ordering doesn't matter, write assertions without assuming any ordering.
In this case, making the order explicit is the simplest fix.