Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4874] Add missing script to the Dockerfile #4898

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 10, 2024

Closes #4874

Changes

  • Added fix_selectboxes_component_default_values scipt to the Dockerfile
  • Updated issue template (reminder for such scripts)
  • Added instructions for downloading and adding the script manually

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (e776c7b) to head (dcce330).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4898   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         757      757           
  Lines       25728    25728           
  Branches     3379     3379           
=======================================
  Hits        24847    24847           
  Misses        616      616           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Dec 10, 2024
.github/pull_request_template.md Outdated Show resolved Hide resolved
docs/installation/additional_scipts.rst Outdated Show resolved Hide resolved
docs/installation/additional_scipts.rst Outdated Show resolved Hide resolved
@vaszig vaszig force-pushed the fix/4874-add-missing-bin-script-to-dockerfile branch from d05cbf6 to 5bdc740 Compare December 11, 2024 07:02
@vaszig vaszig force-pushed the fix/4874-add-missing-bin-script-to-dockerfile branch from 5bdc740 to dcce330 Compare December 12, 2024 08:37
@sergei-maertens sergei-maertens merged commit 3ae753c into master Dec 12, 2024
33 checks passed
@sergei-maertens sergei-maertens deleted the fix/4874-add-missing-bin-script-to-dockerfile branch December 12, 2024 09:42
sergei-maertens pushed a commit that referenced this pull request Dec 12, 2024
sergei-maertens pushed a commit that referenced this pull request Dec 12, 2024
@sergei-maertens
Copy link
Member

Backports:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fix_selectboxes_component_default_values script to the Dockerfile
2 participants