Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Delete migration test code #4901

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

sergei-maertens
Copy link
Member

The tests rely too much on the real models, which breaks other PRs that add additional fields. Refactoring the test code to freeze the price calculation is not reasonable, because it relies on the logic engine evaluation, which can't work with historic models and requires access to the real models and their models.

We'll have to trust that the tests were sufficient when the code cleanup was initially authored :fingers_crossed:

The tests rely too much on the real models, which breaks other PRs that
add additional fields. Refactoring the test code to freeze the price
calculation is not reasonable, because it relies on the logic engine
evaluation, which can't work with historic models and requires access
to the real models and their models.

We'll have to trust that the tests were sufficient when the code
cleanup was initially authored :fingers_crossed:
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing the tests are passing!

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (3e7b959) to head (408c7ec).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4901      +/-   ##
==========================================
- Coverage   96.62%   96.62%   -0.01%     
==========================================
  Files         757      757              
  Lines       25945    25935      -10     
  Branches     3419     3416       -3     
==========================================
- Hits        25069    25059      -10     
  Misses        613      613              
  Partials      263      263              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit 27a9852 into master Dec 10, 2024
33 checks passed
@sergei-maertens sergei-maertens deleted the cleanup/freeze-test-models branch December 10, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants