Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4899] Fix optional serializer fields in ZaakOptionsSerializer #4903

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 11, 2024

Closes #4899

Changes

  • Allow optional url fields to receive empty string values

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig added the needs-backport Fix must be backported to stable release branch label Dec 11, 2024
@vaszig
Copy link
Contributor Author

vaszig commented Dec 11, 2024

I guess this needs-backport as well, or not since it was added last month.

@vaszig vaszig requested a review from robinmolen December 11, 2024 12:48
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm such an idiot

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.62%. Comparing base (27a9852) to head (ec54837).
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4903   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         757      757           
  Lines       25942    25942           
  Branches     3417     3417           
=======================================
  Hits        25066    25066           
  Misses        613      613           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig
Copy link
Contributor Author

vaszig commented Dec 11, 2024

I guess this needs-backport as well, or not since it was added last month.

@sergei-maertens the product_url was added last month from Robin and it's in the Changelog for v3.0, so I am removing the needs-backport label.

@vaszig vaszig removed the needs-backport Fix must be backported to stable release branch label Dec 11, 2024
@vaszig vaszig merged commit e03dbbd into master Dec 11, 2024
33 checks passed
@vaszig vaszig deleted the fix/4899-validationerror-in-zgw-registration branch December 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants