Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for formio-builder #4928

Closed
wants to merge 1 commit into from

Conversation

robinmolen
Copy link
Contributor

@robinmolen robinmolen commented Dec 16, 2024

Part of #2173

Changes

The formio-builder, in the tests, expects a new property. This will be added with map background PR (#4881).

Without this property, the form won't render properly. For the time being, this will fix the issue

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

The map background PR (#4881) will implement this properly.

For the time being, this will fix the issue
@robinmolen robinmolen requested a review from vaszig December 16, 2024 15:05
@robinmolen robinmolen closed this Dec 16, 2024
@robinmolen
Copy link
Contributor Author

Silly idea, not needed

@robinmolen robinmolen deleted the fix/formio-builder-missing-property branch December 16, 2024 15:22
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (c07912d) to head (25761b7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4928   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         758      758           
  Lines       25798    25798           
  Branches     3390     3390           
=======================================
  Hits        24919    24919           
  Misses        613      613           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant