Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 [#3283] Document registration backend migration procedure #4941

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

sergei-maertens
Copy link
Member

Closes #3283

Changes

  • Documented how to migrate registration options
  • Updated comments to reflect real scheduled version for removal

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (99d8c52) to head (29c3bf4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4941   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         760      760           
  Lines       25817    25817           
  Branches     3382     3382           
=======================================
  Hits        24944    24944           
  Misses        608      608           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergei-maertens sergei-maertens force-pushed the chore/3283-document-migration-procedure branch from 6bb9f82 to 29c3bf4 Compare December 18, 2024 11:09
@sergei-maertens
Copy link
Member Author

There is one more place left which (if I am not wrong) needs update.

https://github.com/open-formulieren/open-forms/blob/master/src/openforms/registrations/contrib/objects_api/typing.py#L41

Nice catch, I've updated it!

@sergei-maertens sergei-maertens merged commit f796f25 into master Dec 18, 2024
13 of 15 checks passed
@sergei-maertens sergei-maertens deleted the chore/3283-document-migration-procedure branch December 18, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecations to remove in 3.0
2 participants