Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing test flakiness #4948

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Reducing test flakiness #4948

merged 2 commits into from
Dec 18, 2024

Conversation

robinmolen
Copy link
Contributor

Changes

Making sure that the unique field in mapTileFactory factory uses unique test values

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen requested a review from stevenbal December 18, 2024 10:01
@robinmolen robinmolen marked this pull request as ready for review December 18, 2024 10:01
robinmolen and others added 2 commits December 18, 2024 12:13
Making sure that the unique mapTileLayer identifier uses unique test values
@sergei-maertens sergei-maertens force-pushed the fix/removing-test-flakyness branch from 89c8cab to 6ad0ea7 Compare December 18, 2024 11:27
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (f796f25) to head (6ad0ea7).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4948   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         760      760           
  Lines       25817    25817           
  Branches     3382     3382           
=======================================
  Hits        24944    24944           
  Misses        608      608           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens merged commit b4a32bd into master Dec 18, 2024
32 of 33 checks passed
@sergei-maertens sergei-maertens deleted the fix/removing-test-flakyness branch December 18, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants