-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.msg file upload #4961
base: master
Are you sure you want to change the base?
.msg file upload #4961
Conversation
The removal of the |
6833a2c
to
4908172
Compare
The |
The sdk cannot determine which content type belongs to a .msg file. This is because (at least) Linux and MacOS don't know this file type. To make sure these files can be uploaded, the type property on the FileSerializer is now optional. For .smg files a new rule has been added to the MimeTypeValidator
4908172
to
2d11d04
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4961 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 760 760
Lines 25837 25843 +6
Branches 3385 3388 +3
=======================================
+ Hits 24964 24970 +6
Misses 608 608
Partials 265 265 ☔ View full report in Codecov by Sentry. |
784b49f
to
cc51188
Compare
cc51188
to
5e77364
Compare
Closes #4795
Changes
The sdk cannot determine what content type should be used for .msg files, which results in the content type
""
. When you try to submit the form, the fileSerializer doesn't recognizes the content type and returns an error.To allow the submission of .msg files, the content type should be allowed to be empty.
type
property onFileSerializer
optionalMimeTypeValidator
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene