Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI test failing in stable/2.8.x #4970

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Dec 24, 2024

Changes

This is created in order to fix the stable branch and has to do with the backport of PR 4959

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

This is created in order to fix the stable branch and has to do with the
backport-of: #4959
@vaszig vaszig changed the title Fix CI test failing Fix CI test failing in stable/2.8.x Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (903c8f3) to head (998be27).
Report is 4 commits behind head on stable/2.8.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           stable/2.8.x    #4970   +/-   ##
=============================================
  Coverage         96.54%   96.54%           
=============================================
  Files               746      746           
  Lines             25307    25320   +13     
  Branches           3342     3344    +2     
=============================================
+ Hits              24433    24446   +13     
  Misses              608      608           
  Partials            266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig vaszig merged commit af8c1e2 into stable/2.8.x Dec 24, 2024
29 checks passed
@vaszig vaszig deleted the fix/ci-failing-test branch December 24, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant