-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
✨ [#2] Define type for file component, pt. 1
Mostly describes the base schema and how a single file upload looks like, i.e. what data is chucked over the wire when submitting the form.
- Loading branch information
1 parent
b7e6931
commit 10d7576
Showing
4 changed files
with
166 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
import {DisplayConfig, HasValidation, OFExtensions, StrictComponentSchema} from '../base'; | ||
|
||
type UnusedFileProperties = 'hideLabel' | 'placeholder' | 'disabled' | 'widget' | 'validate'; | ||
|
||
type Validator = 'required'; | ||
type TranslatableKeys = 'label' | 'description' | 'tooltip'; | ||
|
||
/** | ||
* Shape of a single file upload from Form.io to the backend. | ||
*/ | ||
export interface FileUploadData { | ||
data: { | ||
/** | ||
* Full backend URL of the uploaded file (API endpoint). | ||
* | ||
* The value appears to be identical to the root `url` key. | ||
*/ | ||
url: string; | ||
/** | ||
* Does not seems to be set to a meaningful value. | ||
*/ | ||
form: ''; | ||
/** | ||
* File name of uploaded file. | ||
* | ||
* The value is different from the root `name` key. | ||
*/ | ||
name: string; | ||
/** | ||
* File size in bytes, (positive) integer value. | ||
* | ||
* The value appears to be identical to the root `size` key. | ||
*/ | ||
size: number; | ||
/** | ||
* Formio base URL configuration option, set to the root of our own API. | ||
*/ | ||
baseUrl: string; | ||
/** | ||
* Does not seems to be set to a meaningful value. | ||
*/ | ||
project: ''; | ||
}; | ||
name: string; | ||
originalName: string; | ||
/** | ||
* File size in bytes, (positive) integer value. | ||
*/ | ||
size: number; | ||
/** | ||
* We only support file uploads to a backend URL. | ||
*/ | ||
storage: 'url'; | ||
/** | ||
* MIME type, determined by the browser during upload. If the OS/browser doesn't know | ||
* it, it seems to be an empty string (see https://github.com/open-formulieren/open-forms-sdk/ | ||
* blob/27877938249cdd627294871b70291ab8dc66fd61/src/formio/components/FileField.js#L279) | ||
*/ | ||
type: string; | ||
/** | ||
* Full backend URL of the uploaded file (API endpoint). | ||
*/ | ||
url: string; | ||
} | ||
|
||
/** | ||
* @group Form.io components | ||
* @category Base types | ||
*/ | ||
export interface BaseFileComponentSchema | ||
extends Omit<StrictComponentSchema<FileUploadData[]>, UnusedFileProperties | 'errors'>, | ||
DisplayConfig, | ||
OFExtensions<TranslatableKeys>, | ||
HasValidation<Validator> { | ||
type: 'file'; | ||
multiple?: boolean; | ||
} | ||
|
||
export type SingleFileComponentSchema = BaseFileComponentSchema & { | ||
multiple?: false; | ||
defaultValue?: [] | [FileUploadData]; | ||
}; | ||
|
||
export type MultipleFileComponentSchema = BaseFileComponentSchema & { | ||
multiple: true; | ||
defaultValue?: FileUploadData[]; | ||
}; | ||
|
||
/** | ||
* @group Form.io components | ||
* @category Concrete types | ||
* | ||
* Note that while `defaultValue` is defined here, this is only to be able to type | ||
* define the submission data type. A file upload component cannot actually have | ||
* default values. | ||
*/ | ||
export type FileComponentSchema = SingleFileComponentSchema | MultipleFileComponentSchema; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
import {expectAssignable, expectNotAssignable} from 'tsd'; | ||
|
||
import {FileComponentSchema, FileUploadData} from '../../../lib'; | ||
|
||
// Grabbed from test env file upload, URLs obfuscated. | ||
const anUpload: FileUploadData = { | ||
url: 'http://localhost:8000/api/v2/submissions/files/54cc40ed-f1c4-4206-ba76-76d376ba4c3a', | ||
data: { | ||
url: 'http://localhost:8000/api/v2/submissions/files/54cc40ed-f1c4-4206-ba76-76d376ba4c3a', | ||
form: '', | ||
name: 'maykin_logo.png', | ||
size: 8725, | ||
baseUrl: 'http://localhost:8000/api/v2/', | ||
project: '', | ||
}, | ||
name: 'maykin_logo-e0568045-45f6-46d1-909a-8895c5ee061e.png', | ||
size: 8725, | ||
type: 'image/png', | ||
storage: 'url', | ||
originalName: 'maykin_logo.png', | ||
}; | ||
|
||
// minimal file component schema | ||
expectAssignable<FileComponentSchema>({ | ||
id: 'yejak', | ||
type: 'file', | ||
key: 'someFile', | ||
label: 'Attachment', | ||
}); | ||
|
||
// Behaviour of single vs. multiple file uploads | ||
|
||
const explicitSingleUpload: FileComponentSchema = { | ||
id: 'yejak', | ||
type: 'file', | ||
key: 'someFile', | ||
label: 'Attachment', | ||
multiple: false, | ||
}; | ||
type ExplicitSingleUploadValue = (typeof explicitSingleUpload)['defaultValue']; | ||
expectAssignable<ExplicitSingleUploadValue>([]); | ||
expectAssignable<ExplicitSingleUploadValue>([anUpload]); | ||
expectNotAssignable<ExplicitSingleUploadValue>([anUpload, anUpload]); | ||
|
||
const explicitMultipleUpload: FileComponentSchema = { | ||
id: 'yejak', | ||
type: 'file', | ||
key: 'someFile', | ||
label: 'Attachment', | ||
multiple: true, | ||
}; | ||
type ExplicitMultipleUploadValue = (typeof explicitMultipleUpload)['defaultValue']; | ||
expectAssignable<ExplicitMultipleUploadValue>([]); | ||
expectAssignable<ExplicitMultipleUploadValue>([anUpload]); | ||
expectAssignable<ExplicitMultipleUploadValue>([anUpload, anUpload]); | ||
|
||
const implicitSingleUpload: FileComponentSchema = { | ||
id: 'yejak', | ||
type: 'file', | ||
key: 'someFile', | ||
label: 'Attachment', | ||
}; | ||
type ImplicitSingleUploadValue = (typeof implicitSingleUpload)['defaultValue']; | ||
expectAssignable<ImplicitSingleUploadValue>([]); | ||
expectAssignable<ImplicitSingleUploadValue>([anUpload]); | ||
expectNotAssignable<ImplicitSingleUploadValue>([anUpload, anUpload]); |