Skip to content

Commit

Permalink
🐛 iban has no placeholder
Browse files Browse the repository at this point in the history
  • Loading branch information
Viicos committed Nov 10, 2023
1 parent 17777fa commit d1b77fe
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
3 changes: 2 additions & 1 deletion src/formio/components/iban.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ export type IbanInputSchema = InputComponentSchema<string, Validator, Translatab
* @group Form.io components
* @category Base types
*/
export interface BaseIbanComponentSchema extends Omit<IbanInputSchema, 'hideLabel' | 'disabled'> {
export interface BaseIbanComponentSchema
extends Omit<IbanInputSchema, 'hideLabel' | 'disabled' | 'placeholder'> {
type: 'iban';
validateOn: 'blur';
}
Expand Down
11 changes: 10 additions & 1 deletion test-d/formio/components/iban.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {expectAssignable, expectNotAssignable} from 'tsd';

import {IbanComponentSchema} from '../../../lib';

// minimal textfield component schema
// minimal iban component schema
expectAssignable<IbanComponentSchema>({
id: 'yejak',
type: 'iban',
Expand Down Expand Up @@ -127,3 +127,12 @@ expectNotAssignable<IbanComponentSchema>({
multiple: true,
defaultValue: [0],
});

expectNotAssignable<IbanComponentSchema>({
id: 'yejak',
type: 'iban',
key: 'someIban',
label: 'Some IBAN',
validateOn: 'blur',
placeholder: '',
} as const);

0 comments on commit d1b77fe

Please sign in to comment.