Change types for component translation storage #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation storage Rather than storing translations on the entire form definition, we will now track them on the component definition itself. This results in what was internal API/implementation detail to become public API, and the types for this representation are now updated. We store translations in openForms.translations for each component, which itself is a mapping of language code to a mapping of translations. Such a translation mapping has the translatable properties (of the component) as key and the translation as value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-formulieren/open-forms#2958
This is a 💥 breaking change.
Rather than storing translations on the entire form definition, we will now track them on the component definition itself. This results in what was internal API/implementation detail to become public API, and the types for this representation are now updated.
We store translations in openForms.translations for each component, which itself is a mapping of
language code to a mapping of translations. Such a translation mapping has the translatable properties (of the component) as key and the translation as
value.