Implement types for editgrid component #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is a bit special because we're modelling the current situation and some clean up is probably in order, notably: * validation tab doesn't support error messages * validation tab doesn't support validator plugins * button texts are not wired up to be translatable ( fixed in this type definition at least) * missing controls to include field in PDF/email/confirmation page etc., so now it's only hidden if all child components are hidden. The value type can also not be defined statically, because this is a container component that depends on the runtime child components, which in turn dictate the value type of a repeating group itself.
sergei-maertens
force-pushed
the
feature/2-editgrid-type
branch
from
03f8b2a to
0d81964
Compare
Viicos
approved these changes
Dec 6, 2023
| /** | ||
| * Nested components inside the group. | ||
| */ | ||
| components: AnyComponentSchema[]; |
There was a problem hiding this comment.
Can it also be EditGridComponentSchema?
There was a problem hiding this comment.
yeah, I don't see why it couldn't :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #2