Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [open-formulieren/open-forms#4420] Fix AddressNL validation type #52

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Aug 13, 2024

todo clean commit msgs

to allow Validate.useManageValidatorsTranslations typing to be correct in the formio builder

to allow Validate.useManageValidatorsTranslations typing to be correct in the formio builder
@stevenbal stevenbal force-pushed the issue/4420-fix-addressnl-validation-type branch from 729e898 to eb18e6c Compare August 13, 2024 08:20
@stevenbal stevenbal marked this pull request as draft August 13, 2024 08:22
…nition

The validation structure/mechanism now makes use of the HasValidation
helper type, but disables the 'plugins' validators which are not used
or relevant in this context.
@stevenbal stevenbal force-pushed the issue/4420-fix-addressnl-validation-type branch from 7689c96 to 6357bd4 Compare August 19, 2024 10:14
@stevenbal stevenbal marked this pull request as ready for review August 19, 2024 10:14
@sergei-maertens sergei-maertens merged commit d8be868 into main Aug 19, 2024
6 checks passed
@sergei-maertens sergei-maertens deleted the issue/4420-fix-addressnl-validation-type branch August 19, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants