Jak3 Build Environment #3098
Merged
Jak3 Build Environment #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been stubbed out as the previous entries had been taken from Jak2 and were more incorrect.
These have been removed as MUS is no longer part of the iso.
The previous version would generate files by directly copying sections into files named after the headers in dgo.txt, this format didn't match the expectation for use with the build system as each .o/.go filename was output as a pair with it's basename where the build system expects just the filename as a string.
These have been made with generate_dgo_files.py. They may require further manual modification.
This duplcates the Jak2 entry for now, running on the assumption this will still be correct for Jak3.
|
Can one of the admins verify this patch? |
This has been done to fix a decompilation bug caused by not using new types for Jak 3, the condition for this is found in ObjectFileDB_IR2.cpp. Additionally this extends the same update to other matching checks in the decompiler code, running on the base assumption that the Jak 2 treatment will likely be a better default that Jak 1.
|
I've pushed a change for most version == GameVersion::Jak2 checks to make them version >= GameVersion::Jak2 in decompiler |
water111
reviewed
Jan 16, 2024
| @@ -662,7 +662,7 @@ TP_Type SimpleExpression::get_type_int2(const TypeState& input, | |||
| } | |||
| } | |||
|
|
|||
| if (env.version == GameVersion::Jak2 && tc(dts, TypeSpec("symbol"), arg1_type) && | |||
| if (env.version >= GameVersion::Jak2 && tc(dts, TypeSpec("symbol"), arg1_type) && | |||
There was a problem hiding this comment.
I think this one should be reverted. String->symbol is different and shouldn't use the jak2's constant.
|
add to whitelist |
… doesn't like trailing commas! prettier/prettier#15553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets out the bones of a Jak 3 build, many things are stubbed out, guessed, or copied from Jak 2 but it should at least be good enough to:
run
task set-game-jak3launch the repl
run builds from the repl
build outputs themselves are untested but the build itself runs without errors