Parameterize the iso_data folder for goalc #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
xTVaser
reviewed
Oct 4, 2024
There was a problem hiding this comment.
Tested the main use-case on the launcher, it seems to work open-goal/launcher#582
Just one suggestion around cleaning up some of the parameter passing changes.
The compilation check failure is a weird one....i cant really explain what's going on there. I would be surprised if it was related to the PR coming in from a fork but that would be my first guess.
- Nevermind i think it makes sense, I think you uncovered a flaw in that test since the binaries are dynamically linked, and this PR changed a function signature.
I'll have to fix that.Cherry pick this commit dc957f6
Closed
|
With No Paths: With Proj Path only (note: I have my own copy of iso_data inside this mod directory): With Proj Path and ISO Path: Compiling with the last: |
xTVaser
requested changes
Oct 5, 2024
xTVaser
approved these changes
Oct 18, 2024
xTVaser
added a commit
to open-goal/launcher
that referenced
this pull request
Oct 18, 2024
Relies on open-goal/jak-project#3692 This means this change isn't backwards compatible technically, but thats fine because this was technically already broken anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is everything I needed, and nothing I didn't.
What's Changed
This update adds a command-line parameter to goalc,
--iso-path. Providing a path to a directory likeD:\Files\Repositories\ArchipelaGOAL\iso_data\jak1will inform the compiler to use that directory instead.Why is this useful?
When combined with
--proj-path, the compiler can be pointed to a completely different project folder, given the(mi)command, and immediately begin building from that directory, with everything it needs. This eliminates the need to copyiso_datato multipledatadirectories.If a subsequent change to the Launcher is made, each mod could be passed an --iso-path pointing to a single shared folder, allowing mods to each run their own REPL without requiring a copy of
iso_datain a subfolder.Independent testing required!
My local repositories are a little suspect, with a mod, a fork of mod-base, and a fork of jak-project, all on the same drive. My decompiler_out and iso_data folders are in the mod repo, not mod-base nor jak-project. So what I did was make the change in the mod-base fork, point
--proj-path and --iso-pathto the mod folders, and then ran(mi). The output showed a build starting with no errors.Then I had to create this PR, which my fork of mod-base is unable to do, so I created a patch file, forked jak-project, then applied the patch there.
All this is to say that it would be preferable if someone could apply this code to their own installation and see if it works. Even I wouldn't take my own word for this.