-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taskfile: Call 'python3' on non-Windows platforms #3752
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes will break other environments in order for it to work properly on the default homebrew setup, you'd need to extract this into the Taskfile_darwin.yml
file.
I'm not sure if this is definitely the right thing to do either, as even on macOS you can setup your python environment in a myriad of ways so that python
is python3 (ie. pyenv
and since monterary python2 is finally been removed). Considering it's the default for homebrew I'd merge it but the change has to be isolated from windows and linux.
Is there any environment where Plain |
The default installation for Python on Windows does not add a |
|
Do you plan to make the change or should this be closed? |
I don't think using a PEP 394 makes clear that distributors are free to not include a As for Windows, maybe that dynamic variable could be special cased to |
using the There is a desire to use |
Ah I hadn't noticed the scripts/tasks/Taskfile_ files. I moved those vars into the main file (to remove the Mac/Linux duplication), and the Windows file overrides them. |
Can you revert the removal? I'd rather there be a bit of duplication so that they exist when things need to be different between the two environments and so that it is obvious to contributors without having to dig through the taskfile documentation. |
If someone on linux/macOS wanted or needed to change these values, they would have to copy them into the respective file. It would then be potentially confusing which variable is the source of truth (the OS file wins). Avoid this unneeded confusion, having the variables copied into the darwin and linux file is not a big deal.
No description provided.