Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide the imgui bar with a click event #3791

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

Zedb0T
Copy link
Contributor

@Zedb0T Zedb0T commented Dec 3, 2024

Should cover edge cases where the bar is displayed and a keyboard type device is not connected to the system (Steam deck/touch input based device instead).

While it should probably be impossible to display the bar in the first place on such devices it apparently isnt -> https://www.reddit.com/r/jakanddaxter/comments/1h4mht1/how_to_remove_grey_bar_at_top_on_steamdeck/

And even ignoring the whole steamdeck/no keyboard thing adding another way to hide it that is visible on the bar should help reduce people asking about how to hide it. (And hopefully help people who dont ask/dont know where to ask!)

2024-12-02.20-44-48.mp4

@Zedb0T Zedb0T requested a review from xTVaser December 3, 2024 02:01
@Zedb0T
Copy link
Contributor Author

Zedb0T commented Dec 3, 2024

Just to be clear, I did make it match the rest of the bar after recording the example video, but maybe it was a good thing that it had extra emphasis on it?
image

If we go back to the style in the example video it sticks out so much that a end user couldnt possibly miss it right? After all it its a debug/development tool and doesnt have to look "good" it should be hidden for 99% of users anyways.

@water111 water111 merged commit 6e4e5d2 into open-goal:master Dec 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants