Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collision viewer for Jak 1 Custom levels #3813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zedb0T
Copy link
Contributor

@Zedb0T Zedb0T commented Dec 27, 2024

No description provided.

(logior! *vu1-enable-user-menu* (vu1-renderer-mask tfrag trans-tfrag tie tie-near))
(logior! *vu1-enable-user-menu* (vu1-renderer-mask tfrag tie tie-near))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove trans-tfrag here? Not a big deal either way, just curious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I did my binary search to find out where this worked, the bucket that it draws during is in trans-tfrag, and removing it from this call did not change anything else that I noticed during my testing.
image
image

Comment on lines -1307 to +1308
if (bucket_id == 31 - 1 && Gfx::g_global_settings.collision_enable) {
if (bucket_id == (int)jak1::BucketId::MERC_PRIS_LEVEL0 &&
Gfx::g_global_settings.collision_enable) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving this here will break shadows on the collision geometry but I'm not sure. What if you put GENERIC_ALPHA as the bucket instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I binary searched the enum and found an entry that "worked" - I did a test through hub 1 and didn't notice any issues after my change but I can do another test and pay attention to shadows specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants