-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track playtime and display it in the launcher #336
Conversation
Now that jak 2 is available I need to distinguish between them and add the playtime on its game page lol |
…al#335) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…open-goal#332) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…open-goal#340) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…l#339) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…goal#338) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…al#354) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…goal#349) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…open-goal#348) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pdate (open-goal#345) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…en-goal#355) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I took a quick look at this and tried out some things to clean it up, mainly just to show how you can store the time played in the central configuration instead of writing out text files. I was successful NeoFoxxo/launcher@main...xTVaser:v/wip-improvements but uncovered a weird issue. The game seems to take 30-40 seconds to start OpenGL: So the process starts immediately but then nothing happens for a while. I don't really have any ideas why this is happening. I have this same problem when running your original code as well, so something strange is happening for both of us (or i guess, maybe just me lol)
|
I tested it on my machine and it works perfectly! Now I just got to read the settings file on the front end |
Alright I made a rpc function to send the playtime to the front end and its working for me |
Nice sounds good, yeah my issue was some weird driver issue (even got a BSOD when restarting) completely unrelated. I'll give it another test soon as well and then this'll probably be good to go. Thanks for doing the work / waiting around while we got over the jak 2 release hurdle 👍 |
Thanks for getting it to save to the settings file I was struggling with that lol. Also sorry about the formatting i probably should've got my prettier to work |
For the frontend you can run |
… the thread so we can return in the event of an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine for me but I think adding seconds makes the UI more cluttered imo, it looks better with just the minutes. |
That's fair, i added them mostly just so i could quickly test and see it working. I'll revert that portion and merge it then 👍 |
Adds feature requested in #320