Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jak 2 orb counters #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add jak 2 orb counters #18

wants to merge 3 commits into from

Conversation

Zedb0T
Copy link
Contributor

@Zedb0T Zedb0T commented Nov 12, 2023

No description provided.

@Zedb0T Zedb0T requested a review from xTVaser November 12, 2023 01:49
Copy link
Member

@xTVaser xTVaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it just be easier to add an option that splits on any orb pickup (anytime the orb count changes basically)

jak2/opengoal-jak2-autosplitter.asl Outdated Show resolved Hide resolved
@Zedb0T
Copy link
Contributor Author

Zedb0T commented Nov 12, 2023

Would it just be easier to add an option that splits on any orb pickup (anytime the orb count changes basically)

easier and yes bloat? yes. Also less customizable? yes.

I guess with a autosplitter it doesnt really matter, but I wanted to leave the option open for people to only split on last orb in the level etc

@xTVaser
Copy link
Member

xTVaser commented Nov 12, 2023

I guess the only issue is right now it isn't technically guaranteed to be the last orb in the level since it's just purely based off the count. But that's fair.

This will need a new ending condition too (whatever the total orb count for all open orbs is, i assume 95?). For example here's the one i made for all 286 orbs.

AddOption(vars.endingConditions, "endingConditions_all-orbs", 4, typeof(uint), 286, false, "All Orbs", false);

The ending condition is what ensures all splits are exhausted / the timer completes when you finish the run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants