Fix a few more compile warns

open-gpdb · Feb 2, 2025 · 0362158 · 0362158
1 parent 0259025
commit 0362158
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/Makefile b/Makefile
@@ -2,18 +2,15 @@
 
 override CFLAGS = -Wall -Wmissing-prototypes -Wpointer-arith -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -fno-aggressive-loop-optimizations -Wno-unused-but-set-variable -Wno-address -Wno-format-truncation  -g -ggdb -std=gnu99 -Werror=uninitialized -Werror=implicit-function-declaration -DGPBUILD
 
-# -Werror=implicit-fallthrough=3
-
-COMMON_LINK_OPTIONS = -lstdc++ -lz -lstdc++fs -lcrypto
+COMMON_LINK_OPTIONS = -lstdc++
 
 COMMON_CPP_FLAGS = -std=c++11 -fPIC -I/usr/include/libxml2 -I/usr/local/opt/openssl/include -DENABLE_NLS 
 
-override CPPFLAGS = -fPIC -lstdc++fs -lstdc++ -lz -g3 -ggdb -Wall -Wpointer-arith -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fno-aggressive-loop-optimizations -Wno-unused-but-set-variable -Wno-address -Werror=format-security -Wno-format-truncation -Wno-stringop-truncation -g -ggdb -std=c++11 -fPIC -I/usr/local/opt/openssl/include -Iinclude -Ilib  -g -I. -I. -I../../src/include -D_GNU_SOURCE
+override CPPFLAGS = -fPIC -lstdc++fs -lstdc++ -lz -g3 -ggdb -Wall -Wpointer-arith -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fno-aggressive-loop-optimizations -Wno-unused-but-set-variable -Wno-address -Werror=format-security -Wno-format-truncation -g -ggdb -std=c++11 -fPIC -I/usr/local/opt/openssl/include -Iinclude -Ilib  -g -I. -I. -I../../src/include -D_GNU_SOURCE
 
 SHLIB_LINK += $(COMMON_LINK_OPTIONS)
 PG_CPPFLAGS += $(COMMON_CPP_FLAGS) -I./include -Iinclude -Ilib -I$(libpq_srcdir) -I$(libpq_srcdir)/postgresql/server/utils
 
-
 MODULE_big = yezzey
 
 OBJS = \

diff --git a/src/offload_policy.cpp b/src/offload_policy.cpp
@@ -109,8 +109,8 @@ void YezzeyCreateOffloadPolicyRelation() {
 
   /* ShareLock is not really needed here, but take it anyway */
   auto yezzey_rel = heap_open(YEZZEY_OFFLOAD_POLICY_RELATION, ShareLock);
-  char *colname = "reloid";
-  auto indexColNames = list_make1(colname);
+  const char * colname = "reloid";
+  auto indexColNames = list_make1((void*)colname);
 
   auto indexInfo = makeNode(IndexInfo);
 
@@ -441,4 +441,4 @@ void FixupOffloadMetadata(Oid i_reloid) {
 
   /* make changes visible */
   CommandCounterIncrement();
-}
+}