Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicts in pekko-http lib dependencies #725

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Fix conflicts in pekko-http lib dependencies #725

merged 8 commits into from
Oct 29, 2024

Conversation

omordyk
Copy link
Contributor

@omordyk omordyk commented Oct 22, 2024

Description: #724
Failed job: https://github.com/open-horizon/exchange-api/actions/runs/11458070997/job/31879688609?pr=723

Fix conflicts in pekko-http lib dependencies

Changes:

Upgrade version pekko-http from 1.0.1 to 1.1.0.
Update pekko-http-cors, pekko-slf4j to version 1.1.0/ 1.1.1.
Update swagger-pekko-http to version 2.14.0.

Test:

Tested manually on my local development build.

@omordyk omordyk added the docs label Oct 22, 2024
@omordyk omordyk self-assigned this Oct 22, 2024
@omordyk omordyk marked this pull request as ready for review October 22, 2024 10:32
@omordyk omordyk requested a review from naphelps October 22, 2024 10:33
@omordyk omordyk added bug and removed docs labels Oct 22, 2024
build.sbt Show resolved Hide resolved
@naphelps
Copy link
Member

@omordyk Also in the future, when writing your commit prefix the change text with the issue. (ie, "issue 724: My changes are...".

@omordyk omordyk force-pushed the bug_724 branch 2 times, most recently from 33cce70 to 2d09809 Compare October 23, 2024 10:56
- Update Exchange-api to version 2.125.1.
- Library pekko-http-jackson was updated to version 3.0.0.
- Fixed warnings in exchange-api and unit-tests.

Signed-off-by: Oleksandr Mordyk <[email protected]>
Copy link
Member

@naphelps naphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naphelps and others added 3 commits October 23, 2024 09:54
Add Exchange-API quick start document
Signed-off-by: Oleksandr Mordyk <[email protected]>
- Update pekko-http-cors, pekko-slf4j to version 1.1.0.
- Add new dependencies pekko-actor, pekko-stream, pekko-protobuf.

Signed-off-by: Oleksandr Mordyk <[email protected]>
@omordyk omordyk requested a review from geforcelive2 October 24, 2024 15:35
@omordyk
Copy link
Contributor Author

omordyk commented Oct 29, 2024

@omordyk

@naphelps it was fixed in this commit: b65f97a .
It looks like you are pointing to the oldest changes.

- Update pekko-slf4j to version 1.1.1.
- Remove dependencies pekko-actor, pekko-stream, pekko-protobuf.

Signed-off-by: Oleksandr Mordyk <[email protected]>
@omordyk omordyk requested a review from naphelps October 29, 2024 12:29
@naphelps naphelps merged commit 9e05b3f into master Oct 29, 2024
2 checks passed
@naphelps naphelps deleted the bug_724 branch October 29, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants