issue 607: Rework unit-test for VersionSuite #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increased the number of test cases to cover corner cases. - Fixed minor issues found during refactoring. Signed-off-by: Oleksandr Mordyk <[email protected]>
- Fix checking for empty version and invalid start. Signed-off-by: Oleksandr Mordyk <[email protected]>
omordyk
force-pushed
the
issue_607
branch
2 times, most recently
from
96b7f08 to
e8d5b29
Compare
Signed-off-by: Oleksandr Mordyk <[email protected]>
omordyk
changed the title
naphelps
requested changes
Oct 31, 2024
There was a problem hiding this comment.
@omordyk LGTM. The only change I would make is moving the test suite package from src/test/scala/org/openhorizon/exchangeapi/route/version/TestVersion.scala to src/test/scala/org/openhorizon/exchangeapi/utility/version/TestVersion.scala. The suite will have the equivalent package as the source.
Signed-off-by: Oleksandr Mordyk <[email protected]>
|
@naphelps moved. |
naphelps
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue 607: Rework unit-test for version
Description: #607
Changes: