Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Support 2D&3D Optical Flow Training #2631

Merged
merged 11 commits into from
Aug 15, 2023

Conversation

makecent
Copy link
Contributor

@makecent makecent commented Aug 8, 2023

Motivation

Fixing the error when decoding optical flows as now the Normalize pipeline is no longer used. See issue #2630

Modification

Modify the RawFrameDecode transform to stack x_frame and y_frame, making the variable imgs of optical flow consistent with RGB, albeit in channel dimension 2 vs 3.

@Dai-Wenxun Dai-Wenxun changed the title stack flow_x and flow_y in RawFrameDecode [Enhance] Support 2D&3D Optical Flow Training Aug 14, 2023
@Dai-Wenxun
Copy link
Collaborator

LGTM

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.01% ⚠️

Comparison is base (c548788) 76.18% compared to head (2f692fc) 76.17%.
Report is 5 commits behind head on dev-1.x.

❗ Current head 2f692fc differs from pull request most recent head 1c14912. Consider uploading reports for the commit 1c14912 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2631      +/-   ##
===========================================
- Coverage    76.18%   76.17%   -0.01%     
===========================================
  Files          170      170              
  Lines        13792    13780      -12     
  Branches      2361     2360       -1     
===========================================
- Hits         10507    10497      -10     
+ Misses        2718     2716       -2     
  Partials       567      567              
Flag Coverage Δ
unittests 76.17% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mmaction/apis/inference.py 79.59% <28.57%> (-3.21%) ⬇️
mmaction/models/losses/hvu_loss.py 86.36% <50.00%> (+0.20%) ⬆️
mmaction/datasets/transforms/formatting.py 92.12% <100.00%> (-0.52%) ⬇️
mmaction/datasets/transforms/loading.py 81.73% <100.00%> (+0.40%) ⬆️
mmaction/models/heads/tpn_head.py 90.69% <100.00%> (+4.65%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makecent makecent changed the base branch from main to dev-1.x August 15, 2023 06:36
@cir7 cir7 merged commit 96d20d3 into open-mmlab:dev-1.x Aug 15, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants