Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change img.stack to img.concatenate of loadmultichannelimagefromfile #12325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ggamaz
Copy link

@ggamaz ggamaz commented Mar 10, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

when the read images's shape is [h, w, c], stack make the result shape is [h, w, c, n], and concatenate result is [h, w, n*c].
when the read images's channel is not same, stack raise an error, may concatenate is more suit for LoadMultiChannelImageFromFiles

Modification

change np.stack(img, -1) to np.concatenate(img, -1)

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants