[Feature] Full angle range #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Aug 27, 2024
|
I just realized that this repo already is working on 360 rotation detection :P |
|
I think your implementation is better and more flexible. |
|
@calcoloergosum Thank you for your contribution. We will incorporate your angle representation into the main branch as one of the default angle representations. |
zytx121
added a commit
that referenced
this pull request
Sep 28, 2024
yangxue0827
reviewed
Sep 28, 2024
| @@ -80,8 +80,10 @@ def bbox_flip(self, bboxes, img_shape, direction): | |||
| flipped = bboxes.copy() | |||
| if direction == 'horizontal': | |||
| flipped[:, 0] = img_shape[1] - bboxes[:, 0] - 1 | |||
| flipped[:4] = flipped[[1, 0, 3, 2]].copy() | |||
There was a problem hiding this comment.
This new line of code will produce incorrect image flips, especially for the original centered representation. Please check it and fix it.
| elif direction == 'vertical': | ||
| flipped[:, 1] = img_shape[0] - bboxes[:, 1] - 1 | ||
| flipped[:4] = flipped[[1, 0, 3, 2]].copy() |
There was a problem hiding this comment.
This new line of code will produce incorrect image flips, especially for the original centered representation. Please check it and fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR alone does not make training work.
Thank you for your amazing codebase.
Motivation
Resolve #386 #565 #902 #1045 . Sometimes we want the full range of angle.
Modification
angle_versioncalled "full360".Use cases (Optional)
Anything that is not rotation invariant shaped objects.
For example:
Note
For code in this PR, bounding box is defined to be the clockwise -
(lt, rt, br, bl)or[(-,-), (-,+), (+,+), (+, -)].RBBoxAssignershould be modified accordingly.Checklist