Skip to content

Features/graphviz-integration #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eosram
Copy link

@eosram eosram commented Jun 7, 2020

This is similar to my previous pull request #2 , but deals with the images. As a proof of concept I've written graph descriptions for the VRE-units in the DOT language. It is plain text, so version control is easy. More important this could make it easier for us to harmonize layout and labeling.

eosram added 2 commits June 7, 2020 23:23
Graphs for `VRE-units` are described in the DOT language.
@eosram eosram added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 7, 2020
@eosram eosram requested a review from IdaGJ June 7, 2020 21:57
@eosram
Copy link
Author

eosram commented Jun 7, 2020

Ah, for this to work graphviz has to be installed on your system, but a Windows installer is available on the website. i also found this discussion on Google groups, that might be relevant:

@IdaGJ
Copy link

IdaGJ commented Jun 26, 2020

Martin, I think it is a great idea with this graphviz. Could you maybe add what one needs to do to be able to use it in the readme file (as you write here that you need to install it on your system)? Then I would happily accept your pull request :-)

@eosram
Copy link
Author

eosram commented Jun 29, 2020

Thank you for your feedback! I've now updated the README file accordingly to include the Graphviz dependency. : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants