Write MAC egress command at correct offset #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: - MAC_PREPEND_BYTES is defined as 4 bytes Packet contains 8 bytes of metadata (4B timestamp + 4B MAC ingress) Payload starts at PKT_NBI_OFFSET + 8 bytes - pkt_mac_egress_cmd_write() adds the cmd at offset - 4. offset must point to payload start (refer to flowenv/lib/pkt.h) - pkt_msd_write() accepts offset to payload (or the MAC egress command that may precede it). Length and Offset must include the MAC egress command that is prepended to payload. - Causes random packet corruption in TCP packets without this change! Signed-off-by: Rajath Shashidhara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
Packet contains 8 bytes of metadata (4B timestamp + 4B MAC ingress)
Payload starts at PKT_NBI_OFFSET + 8 bytes
offset must point to payload start (refer to flowenv/lib/pkt.h)
that may precede it). Length and Offset must include the MAC egress
command that is prepended to payload.
Signed-off-by: Rajath Shashidhara [email protected]