Skip to content

Commit

Permalink
qemu: Support chardevs with ARM virt machines
Browse files Browse the repository at this point in the history
The function to check if -chardev is supported by QEMU was written a
long time ago, where adding chardevs did not make sense on the fixed ARM
platforms.  Since then, we now have a general purpose virt platform,
which should support plugging in any device over PCIe which is supported
in a similar fashion on x86.

Signed-off-by: Christoffer Dall <[email protected]>
Reviewed-by: Andrea Bolognani <[email protected]>
  • Loading branch information
Christoffer Dall authored and andreabolognani committed Jun 25, 2017
1 parent 41eb927 commit 70c9b44
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/qemu/qemu_capabilities.c
Original file line number Diff line number Diff line change
Expand Up @@ -5573,6 +5573,11 @@ virQEMUCapsSupportsChardev(const virDomainDef *def,
if ((def->os.arch != VIR_ARCH_ARMV7L) && (def->os.arch != VIR_ARCH_AARCH64))
return true;

/* The virt machine has a PCIe bus and allows plugging in the same type of
* devices as x86 systems do on a PCIe bus. */
if (qemuDomainIsVirt(def))
return true;

/* This may not be true for all ARM machine types, but at least
* the only supported non-virtio serial devices of vexpress and versatile
* don't have the -chardev property wired up. */
Expand Down

0 comments on commit 70c9b44

Please sign in to comment.