-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pybind11 experimental lift entry watchdog #96
base: main
Are you sure you want to change the base?
Feature/pybind11 experimental lift entry watchdog #96
Conversation
…ry_watchdog Signed-off-by: Tong-Kiat Tan <[email protected]>
Signed-off-by: Tong-Kiat Tan <[email protected]>
e118271
to
355777b
Compare
I know these are unstable APIs. I'll amend them if/when the C++ function and/or enum changes. Also, I'm wondering whether it's OK if I contribute the python version of the full_control fleet_adapter. In addition, I'm thinking of writing an accompanying article or note to help more people implement their own fleet_adapters. I hope this will pique the interest of more causal tinkerers (like me) and, perhaps, encourage/nudge these people to experiment or adopt RMF for their own just-for-fun projects. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Overall this looks good, just dropped in one small comment.
For sure we absolutely welcome any external contributions and encourage people to try out RMF! On a side note, you can also refer to our mir fleet adapter: https://github.com/osrf/fleet_adapter_mir/. Also we will soon (in this few weeks) release another py-based fleet adapter example template for easy integration, hopefully this can be a good reference for you. Will drop in the link once it's ready.
auto m_robot_update_handle = m.def_submodule("robot_update_handle"); | ||
|
||
py::enum_<agv::RobotUpdateHandle::Unstable::Decision>( | ||
m_robot_update_handle, "Decision") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can explicitly mention this as unstable
, or create an unstable def_submodule
.
Added some python bindings
Added python binding for C++ function
rmf_fleet_adapter::agv::RobotUpdateHandle::Unstable::set_lift_entry_watchdog
.Added python binding for C++ enum
rmf_fleet_adapter::agv::RobotUpdateHandle::Unstable::Decision
.