Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined behavior in plan cleanup #106

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix undefined behavior in plan cleanup #106

merged 1 commit into from
Dec 21, 2023

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Dec 21, 2023

This PR fixes some undefined behavior that can happen when trying to remove unnecessary motions from a plan. We were accidentally dereferencing an optional that may have a nullopt value.

Signed-off-by: Michael X. Grey <[email protected]>
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1f4ddb5) 21.71% compared to head (099fbbd) 21.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   21.71%   21.71%           
=======================================
  Files         361      361           
  Lines       30302    30302           
  Branches    14200    14200           
=======================================
  Hits         6580     6580           
  Misses      14218    14218           
  Partials     9504     9504           
Flag Coverage Δ
tests 21.71% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
..._traffic/agv/planning/DifferentialDrivePlanner.cpp 40.98% <0.00%> (ø)

@mxgrey mxgrey merged commit 61b4a4d into main Dec 21, 2023
11 checks passed
@mxgrey mxgrey deleted the fix_plan_squashing branch December 21, 2023 13:58
mxgrey added a commit that referenced this pull request Dec 21, 2023
Signed-off-by: Michael X. Grey <[email protected]>
mxgrey added a commit that referenced this pull request Dec 21, 2023
Signed-off-by: Michael X. Grey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant