Speed up pagination for pit_crew #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <[email protected]>
|
PS: I don't know why DCO is failing even though I have a signoff. |
|
Looks good! It seems the DCO expected @google.com but got @gmail.com instead, but I think that's OK. |
luca-della-vedova
approved these changes
Apr 5, 2024
koonpeng
pushed a commit
that referenced
this pull request
Jun 12, 2024
Signed-off-by: methylDragon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default number of models that fuel returns is 20. This PR makes the number of models returned per page 5x larger, meaning fewer calls are made, and pagination completes much faster.
Setting the
per_pageto higher than 100 causes fuel to reject the arg and drop you back down to 10 models per page.This mostly impacts people building from scratch, since the greatest impact is on initial building of the model cache.