Cherry-pick Shapely 1.8.0 deprecations (#496, #476) #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiyu Oh <[email protected]> Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
force-pushed
the
luca/humble-cp-496
branch
from
be428dc to
6480104
Compare
xiyuoh
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
I can verify that the deprecation warning is printed when building the current humble branch in a 22.04/Humble distrobox:
/home/xiyuoh/ws_osrf/rmf_ws/install/rmf_building_map_tools/lib/python3.10/site-packages/building_map/floor.py:144: ShapelyDeprecationWarning: Iteration over multi-part geometries is deprecated and will be removed in Shapely 2.0. Use the `geoms` property to access the constituent parts of a multi-part geometry.
for item in geom:
From experience our deployment partners using RMF Humble benefited from the fix so I'm good with this cherry pick. Also tested this fix in the same workspace and there were no errors or warnings.
We should backport #476 as well since they're targeting the same shapely update, and it is also the line that the above warning is complaining about.
I was trying a clean build of RMF Demos and ran into a type error when trying to compile maps. This PR fixes the type error. I'm not sure what triggered it in the first place TBH. Signed-off-by: Arjo Chakravarty <[email protected]> Co-authored-by: Yadunund <[email protected]> Signed-off-by: Luca Della Vedova <[email protected]>
|
Very good point, I missed that 7d67455 |
luca-della-vedova
changed the title
luca-della-vedova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Cherry pick #496 to
humble, from what I understand the version that is shipped in Ubuntu 22.04 is 1.8.0. Also from what I understand shapely 1.8.0 prints a deprecation warning https://shapely.readthedocs.io/en/stable/migration.html#multi-part-geometries-will-no-longer-be-sequences-length-iterable-indexable so this should be OK to backport (and avoid issues for people that might have a newer version of shapely but are using thehumblerepos).Note that I don't have a 22.04 machine so I couldn't really test this